Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: position sticky-header highlighter with css grid #9186

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

brendankenny
Copy link
Member

alternative fix to #9167

Putting the sticky-header highlighter in the first gauge was a nice way to get it positioned correctly on load and a good transform origin to translate from on scroll, but it ends up a little weird since it's fundamentally part of the sticky header, not a single gauge.

Moving it out of the gauge, though, I couldn't find a way to get an absolutely positioned element to be aligned with the first gauge using flexbox. CSS grid makes this really easy, though, so switched the sticky header to using that.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grid! so cool.

nice solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants