Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add performance-budgets to related projects #8971

Merged
merged 3 commits into from
May 18, 2019
Merged

docs(readme): add performance-budgets to related projects #8971

merged 3 commits into from
May 18, 2019

Conversation

boyney123
Copy link
Contributor

Was excited with the new release of budgets within lighthouse. I added a new tool that uses Docker to create an image with chrome and lighthouse that allows developers to easily set budgets.

Was excited with the new release of budgets within lighthouse. I added a new tool that uses Docker to create an image with chrome and lighthouse that allows developers to easily set budgets.
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice @boyney123 thanks for the contribution!

You might be interested in https://github.com/GoogleChrome/lighthouse-ci which hopes to add explicit budget support like this soon too :)

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@boyney123
Copy link
Contributor Author

You might be interested in GoogleChrome/lighthouse-ci which hopes to add explicit budget support like this soon too :)

Hey @patrickhulce thanks for reviewing the PR 👍

Yeah, I have seen and kept my eye on lighthouse-ci 👍, looking forward to seeing what happens there. I'm also planning to add more budget options with this tool in the future too, so hopefully, that can help people 🤷‍♂

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants