tests: fix smoketests from sharing artifacts #8897
Conversation
| const args = [ | ||
| 'lighthouse-cli/index.js', | ||
| url, | ||
| `--config-path=${configPath}`, | ||
| `--output-path=${outputPath}`, | ||
| '--output=json', | ||
| `-GA=${artifactsDirectory}`, | ||
| `-G=${artifactsDirectory}`, | ||
| `-A=${artifactsDirectory}`, |
There was a problem hiding this comment.
any reason to split these up
There was a problem hiding this comment.
yup.
node lighthouse-cli/index.js http://localhost:10200/seo/seo-tester.html?extra_header=link%3D%253Chttp%253A%252F%252Flocalhost%253A10200%252Fseo%252F%253E%253B%2Brel%253D%2522canonical%2522 --config-path=/Users/paulirish/code/pristine/lighthouse-pristine/lighthouse-cli/test/smokehouse/seo-config.js --output-path=smokehouse-83625.report.json --output=json -GA=./.tmp/smokehouse-artifacts-83625
|
nice find |
this is a problem for |
oh, yes, that's correct, but also fine. It's just smokehouse itself running into this. Need something like // Artifacts are undefined if they weren't written to file (e.g. if there was an error).
let artifacts;
try {
artifacts = JSON.parse( fs.readFileSync(`${artifactsDirectory}/artifacts.json`, 'utf8'));
} catch (e) {}down on L119 of |
No description provided.