Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix roundtrip #8815

Merged
merged 1 commit into from
May 2, 2019
Merged

misc: fix roundtrip #8815

merged 1 commit into from
May 2, 2019

Conversation

paulirish
Copy link
Member

just ran yarn update:sample-json on master and this is the diff i got.

curious if everyone else has the same changes?

@connorjclark
Copy link
Collaborator

node version?

@paulirish
Copy link
Member Author

node --version
v11.13.0

@connorjclark
Copy link
Collaborator

I get the same w/ v10.14.2

@paulirish
Copy link
Member Author

lgtm me then ? :)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny
Copy link
Member

can confirm I get the same diff on 11.13.0 as well

"title": "Keep request counts low and transfer sizes small"
},
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems...not ideal :) why is adding so many extra spaces and useless .0s?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the trailing spaces in #8818, we could try to get rid of the useless .0s, but it's messier...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants