Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(redesign): adjust score scale to match new design #8590

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

connorjclark
Copy link
Collaborator

margin: 0 12px;
font-family: var(--monospace-font-family);
white-space: nowrap;
}

.lh-scorescale-range::before {
content: '';
width: var(--body-font-size);
height: calc(var(--body-font-size) * .50);
width: 18px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we var these babies up somewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM though I agree with @hoten's suggestion to do a bunch of pixel-perfect fixes in one swoop than try to split them up :)

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree that these pixel adjustments can be bundled

@connorjclark
Copy link
Collaborator Author

lgtm b/c it's pretty isolated (and done :))

I'll use #8591 for the rest of the pixel pushing

@paulirish paulirish merged commit 41879ad into master Apr 25, 2019
@paulirish paulirish deleted the rd-score-scale branch April 25, 2019 16:50
@connorjclark connorjclark mentioned this pull request Apr 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants