Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(redesign): hide sparkline in mobile #8562

Merged
merged 2 commits into from
Apr 29, 2019
Merged

report(redesign): hide sparkline in mobile #8562

merged 2 commits into from
Apr 29, 2019

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark mentioned this pull request Apr 23, 2019
Closed
55 tasks
paulirish
paulirish approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment on why we do this?

@connorjclark
Copy link
Collaborator Author

done

patrickhulce
patrickhulce approved these changes Apr 25, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this was our compromise to get to keep them in the regular report? 😁

exterkamp
exterkamp approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think this is a fair compromise.

@paulirish paulirish merged commit 3330927 into master Apr 29, 2019
@paulirish paulirish deleted the report-ui-sparkline-hide-mobile branch April 29, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

@exterkamp exterkamp exterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @patrickhulce @exterkamp