report(redesign): dark theme #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you mind rebasing/renaming the PR to remove the merge blockers? |
|
renamed. I don't understand how rebasing would remove the other two failures. The CLA? |
for whatever reason the Travis merge with master isn't picking up #8583, so rebase/merge with master would force it to include the fix |
|
my track record with rebasing is awful, but I think just merging master back in will do the trick. |
|
? |
|
btw: git commit --allow-empty -m "empty commit to trigger CI" |
paulirish
approved these changes
Apr 25, 2019
| * @param {KeyboardEvent} e | ||
| */ | ||
| onKeyUp(e) { | ||
| if (e.key === 'd') { |
There was a problem hiding this comment.
this seems fine for development, but I don't think we should leave it in.
either remove now that we're done with this PR or remove in a week?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8185
Merge base is a branch I made w/ #8222 and #8307.merged in master.Still need to do the PWA badge, and inline some svgs (it prevents duplicating by letting CSS change the colors. Only inlining svgs that would get used just once.)