core(artifacts): create a PublicGathererArtifacts type #8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 18, 2019
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| const Gatherer = require('./gatherer'); | |||
|
|
|||
| class ChromeConsoleMessages extends Gatherer { | |||
| class ConsoleMessages extends Gatherer { | |||
|
(looks like there are a few more that are simple/stable that we can move over, but we aren't in a rush) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In conjuction with #8381, this moves us to blessed artifacts. The only non-typing change is to
ChromeConsoleMessageswhich just removes theChromeprefix. IMO, that feels more like the public API we might want to expose, but it's a trivial change if we want to revert.Our friends at adspeed only use
ViewportDimensions,IFrameElements,devtoolsLogs, andtraces. We haven't createdIFrameElementsyet but we can always increase the scope of our blessed artifacts later.After discussion with @brendankenny and @paulirish, we'll probably rely on documentation to prevent folks from venturing too far on their own with computed artifacts.
Related Issues/PRs
#8381