Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(lr): apply Lightrider timings to NetworkRequests #8109

Merged
merged 5 commits into from
Apr 10, 2019

Conversation

exterkamp
Copy link
Member

Summary
Follow up to #7888 which now actually applies those LR timings.

Call out if I forgot to re-add anything.

lighthouse-core/lib/network-request.js Show resolved Hide resolved
lighthouse-core/lib/network-request.js Show resolved Hide resolved
lighthouse-core/lib/network-request.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so stoked to see how this changes things! 🎉

lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/network-request-test.js Outdated Show resolved Hide resolved
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait on the call on whether or not to always start with a fresh timing

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickhulce patrickhulce merged commit ca1731a into master Apr 10, 2019
@patrickhulce patrickhulce deleted the apply-lr-timings branch April 10, 2019 14:03
exterkamp added a commit that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants