misc(viewer): fix types to reference LH.Result #7051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Jan 17, 2019
| @@ -80,7 +80,7 @@ class ReportUIFeatures { | |||
| /** | |||
| * Adds export button, print, and other functionality to the report. The method | |||
| * should be called whenever the report needs to be re-rendered. | |||
| * @param {LH.ReportResult} report | |||
| * @param {LH.Result} report | |||
| */ | |||
| initFeatures(report) { | |||
There was a problem hiding this comment.
should also drop the Util.prepareReportResult in report-ui-features-test.js
(that is a seriously anemic test file for the amount of jsdom setup it does :)
| @@ -132,7 +132,7 @@ class LighthouseReportViewer { | |||
| } | |||
|
|
|||
| /** | |||
| * @param {LH.ReportResult} json | |||
There was a problem hiding this comment.
Really all the callers to this are either doing it with any or have casted any, so this is kind of a lie.
json should really have type unknown and we could have _validateReportJson verify that it's an LH.Result (as it's superficially doing already), but that can be a project for another day.
Should we add a TODO or file an issue?
paulirish
force-pushed
the
viewertypes
branch
from
bd02934
to
10e9177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're dealing with the real LHR here, not the ReportResult. Not sure how this happened but it's funny.
(EDIT: it was me :)