fix(report): edge Invalid argument error #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue: Demo: |
paulirish
requested changes
Nov 2, 2018
| @@ -127,7 +127,8 @@ class DetailsRenderer { | |||
| displayedHost = parsed.file === '/' ? '' : `(${parsed.hostname})`; | |||
| title = url; | |||
| } catch (/** @type {!Error} */ e) { | |||
| if (!e.name.startsWith('TypeError')) { | |||
| // All browsers throw a TypeError except Edge they throw a regular Error with Invalid argument as a message | |||
| if (!e.name.startsWith('TypeError') && !e.message.startsWith('Invalid argument')) { | |||
There was a problem hiding this comment.
i think we could afford to remove this if (...) { throw e; } block entirely.
Here's the history:
From what I can tell, we might as well just discard any exception here. Throwing at this point seems.. bad. :)
@patrickhulce sgty?
There was a problem hiding this comment.
i'm fine with that! :)
paulirish
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seo font-size audit has a 'Legible Text' value in an url column. Inside the report we run
new URL('Legible Text');which throws an error in all browsers. We catch it by checking e.name is typeError. Edge just throws an Error with Invalid Argument as a message. We now support both.Related Issues/PRs
#6444