Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(config): faster category validation #6445

Merged
merged 3 commits into from
Nov 1, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
On my machine 90% of the non-requireing time spent in config:init was just validating the categories. Simple conversion of this .find to a map eliminated ~60ms.

Related Issues/PRs
#6442

@paulirish
Copy link
Member

60ms! Hot damn.

Nice one.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@patrickhulce
Copy link
Collaborator Author

60ms! Hot damn.

I can't tell if that's sarcasm or not 😆

@patrickhulce patrickhulce merged commit 76ec168 into master Nov 1, 2018
@patrickhulce patrickhulce deleted the faster_config_init branch November 1, 2018 19:47
@paulirish
Copy link
Member

60ms! Hot damn.

I can't tell if that's sarcasm or not 😆

It's not. I think this points to the wins of profiling-guided development. Pretty awesome.

@patrickhulce patrickhulce mentioned this pull request Nov 21, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants