Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(driver): save performance.now() to avoid conflict #6387

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Conversation

paulirish
Copy link
Member

much like #6283 I've found some more of these in our logs. performance.now in particular seems to be overwritten in some places.

oh and fixed one spot where we weren't using our own __nativePromise.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a smoke test for this?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

One unfortunate thing is that the error in the smoketest ends up as an unhandled promise rejection, so the test actually still passes. I wonder if
a) unhandled promise rejections should fail smokehouse
b) we can make exceptions in the very complicated Driver._waitForFullyLoaded() execution path actually make it into the main execution chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants