Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: enforce linting for infix-op spacing #6382

Merged
merged 1 commit into from
Oct 24, 2018
Merged

misc: enforce linting for infix-op spacing #6382

merged 1 commit into from
Oct 24, 2018

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Oct 24, 2018

based on this: #6286 (review) :)

It's surprising we don't enforce spacing around ternary operators, etc already. Enabled the eslint rule to enforce it. The few places where we were breaking seem like things we would normally correct anyways, so it seems reasonable to leave it enforced.

@patrickhulce
Copy link
Collaborator

I was wondering why eslint wasn't catching those :)

@brendankenny brendankenny merged commit 06f5bd9 into master Oct 24, 2018
@brendankenny brendankenny deleted the spaces branch October 24, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants