Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(errors): re-source page load errors and class rename #5972

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

brendankenny
Copy link
Member

helping out with #5881, this fixes the fact that page load errors currently have a stack that points to GatherRunner.getPageLoadError() but are actually thrown down in GatherRunner.collectArtifacts().

Also renames the errors.js file because we always refer to it as LHError anyways :)

@brendankenny brendankenny merged commit 6d823c0 into master Sep 6, 2018
@brendankenny brendankenny deleted the errors branch September 6, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants