misc(logger): add time/timeEnd methods #5905
Conversation
| @@ -6,6 +6,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| const debug = require('debug'); | |||
| const marky = require('marky'); | |||
lighthouse-logger/index.js
Outdated
|
|
||
| static timeEnd({msg, id, args=[]}, level='verbose') { | ||
| Log[level]('statusEnd', msg, ...args); | ||
| return marky.stop(id); |
There was a problem hiding this comment.
is this going to be used? Should update lighthouse-logger/index.d.ts or drop the return here?
lighthouse-logger/index.js
Outdated
| @@ -207,5 +219,10 @@ class Log { | |||
| } | |||
|
|
|||
| Log.events = new Emitter(); | |||
| Log.getEntries = _ => { | |||
There was a problem hiding this comment.
I realize this (appears) to be going for the same getEntries() name as the Performance.getEntries(), but it's definitely confusing in the context of a logger (where you might expect it to return all log entries).
WDYT about Log.getTimeEntries()?
There was a problem hiding this comment.
I had the same feeling as well, will do 👍
There was a problem hiding this comment.
settled on takeTimeEntries to mimic the semantics and name of PerfObserver 👍
lighthouse-logger/index.js
Outdated
| @@ -207,5 +219,10 @@ class Log { | |||
| } | |||
|
|
|||
| Log.events = new Emitter(); | |||
| Log.getEntries = _ => { | |||
There was a problem hiding this comment.
maybe make this a getter instead of a function. No big deal though
|
|
In order to land #3745, we need logger to be published with the new functionality. This is just the
lighthouse-loggerportion of #3745 with a version bump to1.1.0