Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: all ByteEfficiency audits require a trace #5840

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

paulirish
Copy link
Member

fixes a bug where running this cmd emits 'cannot read traceEvents of undefined':

lighthouse -A --only-audits=uses-optimized-images  http://cnn.com

these audits don't require it for the audit necessarily, but lantern is used for the savings calculation and thus we need the trace to build the dependencyGraph.

this seems more straightforward than dealing with the inheritance of audit.meta.requiredArtifacts[]

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulirish paulirish merged commit adde651 into master Aug 15, 2018
@paulirish paulirish deleted the byteeffneedtraces branch August 15, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants