-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: responsive styles #5706
Conversation
cc @hwikyounglee take a look at both. :) |
feeling left out here @paulirish 😛 was just wondering if there is any browser list that lightsights should support? |
Updated the demo URLs. The PSI one gets a fix to the dancing width bug that Rui noticed. @hwikyounglee any feedback from your side? later: hwi hooked me up with https://paste.googleplex.com/6062741227831296 |
bbdc667
to
4a5edda
Compare
Revised styles applied. Most noticeably there are fewer horizontal rules in the report (between passed audits/notapplicable) and between perf/pwa/a11y categories. Also some whitespace adjustments. updated linkshttps://bitter-care2.surge.sh/cnn.html Lightsights report: |
@brendankenny anything stand out to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is the lighthouse side of some work for Lightsights.
changes
Demo:
https://bitter-care.surge.sh/cnn.html
https://bitter-care.surge.sh/z.devtools.cnn.html
This plus some more PSI styles gives the.. Lightsights report:
https://goto.google.com/anxlo (🔒 googlers only)