Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: responsive styles #5706

Merged
merged 3 commits into from
Aug 9, 2018
Merged

report: responsive styles #5706

merged 3 commits into from
Aug 9, 2018

Conversation

paulirish
Copy link
Member

This is the lighthouse side of some work for Lightsights.

changes

  • 2 columns squeeze to 1. rename column classes to be more general]
  • drop the left padding on audit details always. even when we're in a wide viewport
  • updated icons for metrics & diagnostics
  • filmstrip responsiveness
  • top nav score headers dont squish so much anymore.
  • a few other small things

Demo:

https://bitter-care.surge.sh/cnn.html
https://bitter-care.surge.sh/z.devtools.cnn.html

This plus some more PSI styles gives the.. Lightsights report:
https://goto.google.com/anxlo (🔒 googlers only)

@paulirish
Copy link
Member Author

cc @hwikyounglee take a look at both. :)

@wardpeet
Copy link
Collaborator

feeling left out here @paulirish 😛

was just wondering if there is any browser list that lightsights should support?

@paulirish
Copy link
Member Author

paulirish commented Jul 30, 2018

Updated the demo URLs. The PSI one gets a fix to the dancing width bug that Rui noticed.

@hwikyounglee any feedback from your side?


later: hwi hooked me up with https://paste.googleplex.com/6062741227831296

@paulirish
Copy link
Member Author

Revised styles applied. Most noticeably there are fewer horizontal rules in the report (between passed audits/notapplicable) and between perf/pwa/a11y categories. Also some whitespace adjustments.

updated links

https://bitter-care2.surge.sh/cnn.html
https://bitter-care2.surge.sh/z.devtools.cnn.html

Lightsights report:
https://goto.google.com/fhofqb (🔒 googlers only)

@paulirish
Copy link
Member Author

@brendankenny anything stand out to you?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulirish paulirish merged commit 6100528 into master Aug 9, 2018
@paulirish paulirish deleted the responsive-lh branch August 9, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants