core(simulator): add DNS timing #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds DNS timing information to the lantern simulator. Huge improvement to the first paint estimates, pretty good improvements to the TTI estimates as well. I think this moves us into a position to eliminate the intercept and just do a 50/50 blend of optimistic/pessimistic estimates. Ideally we address #5599.
These are the new stats with just 50/50 except TTFCPUI which just uses the optimistic straight up.
Related Issues/PRs
blocked on #5606 and #5523I'll update test failures/expectations once those get through.Updated!