Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: expose devtools hooks reliably #5579

Merged
merged 11 commits into from
Jun 29, 2018
Merged

extension: expose devtools hooks reliably #5579

merged 11 commits into from
Jun 29, 2018

Conversation

paulirish
Copy link
Member

No description provided.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// If not require()d, expose on window for devtools, other consumers of file.
}

if (window) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeof window !== 'undefined' maybe? :)

@paulirish paulirish merged commit 4542ab6 into master Jun 29, 2018
@paulirish paulirish deleted the windowguard branch June 29, 2018 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants