tests(smoke): remove console.timeline() call #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Jun 26, 2018
| @@ -17,7 +17,7 @@ module.exports = [ | |||
| score: 0, | |||
| details: { | |||
| items: { | |||
| length: '>3', | |||
| length: 5, | |||
patrickhulce
commented
Jun 26, 2018
| @@ -306,8 +306,6 @@ <h2>Do better web tester page</h2> | |||
| MediaStreamTrack.getSources(); // Should eventually FAIL | |||
| } catch(e) {} | |||
|
|
|||
| console.timeline(); // Should eventually FAIL | |||
There was a problem hiding this comment.
the Should eventually FAIL seems to be a signal that at some point in the future we expected that this would trigger a deprecation?
we assert that 3 deprecations are found in our expectations, the 3 real ones + 2 fake ones (no more fake ones after this PR)
paulirish
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulirish bisected the regression to a V8 roll that removed console.timeline, we call this method in our smoke tests so the test script was erroring and not actually executing our intentional failures :)