Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(scripts): better print-correlations output #5523

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

patrickhulce
Copy link
Collaborator

basically a total re-write of the print-correlations script, example new output looks like the below and compares the current state to the baseline master state as well! 🎉

image

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the screenshot:

  • what does the %error of optimistic/pessimistic numbers mean since there is nothing "real" to measure them against?
  • good/ok/bad buckets are sites that are good/ok/bad or sites where the lantern estimate is good/ok/bad? (I assume the lantern estimate since it's listing the bad number going down as green?)

@patrickhulce
Copy link
Collaborator Author

what does the %error of optimistic/pessimistic numbers mean since there is nothing "real" to measure them against?

it's also measuring them against the real value, mostly this is for tracking how close the raw optimistic/pessimistic values are without any adjustments :)

good/ok/bad buckets are sites that are good/ok/bad or sites where the lantern estimate is good/ok/bad?

correct

@paulirish
Copy link
Member

@brendankenny any last thoughts on this one?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any last thoughts on this one?

no, seems fine

@patrickhulce patrickhulce merged commit dc0a4a4 into master Jul 3, 2018
@patrickhulce patrickhulce deleted the better_lantern_accuracy_metrics branch July 3, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants