extension: another speculative fix for getCurrentTabURL; more logging #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
May 23, 2018
| } | ||
| if (tabs.length > 1) { | ||
| log.warn('ExtensionConnection', '_queryCurrentTab returned multiple tabs'); | ||
| } | ||
| resolve(tabs[0]); | ||
|
|
||
| const firstUrledTab = tabs.find(tab => !!tab.url); |
There was a problem hiding this comment.
heh, firstUrledTab :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for "getCurrentTabURL returned empty string".
Uses Patrick's idea to pick the first tab with a URL. Unclear if there will actually be a tab with a url (maybe there are no other tabs provided since we ask only for the active tabs in the current window) but it won't hurt the current correct cases where the first tab has a URL.
In addition, added more detailed error messages that may give us some hints for what's going on
runnerthat fails the first URL exists check (Extension Error: You must provide a url to the runner #1834)chrome.tabs.TAB_ID_NONE, which is set for "for apps and devtools windows)). I don't see anything else in that property list that leaps out as helping to debug, but happy to add others.