Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(viewer): fix saving as gist #5251

Merged
merged 1 commit into from
May 17, 2018
Merged

misc(viewer): fix saving as gist #5251

merged 1 commit into from
May 17, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented May 17, 2018 •
edited
Loading

  1. some .url that weren't yet .finalUrl
  2. a regression from brendan's tsc that nuked a !
  3. driveby fix for a path in roll-to-devtools.sh

fixes #5250

brendankenny
brendankenny approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulirish paulirish added the 3.0 label May 17, 2018
@paulirish paulirish merged commit 46e49f4 into master May 17, 2018
@paulirish paulirish deleted the fixgist branch May 17, 2018 20:52
@brendankenny brendankenny mentioned this pull request May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@ebidel ebidel Awaiting requested review from ebidel

@vinamratasingal-zz vinamratasingal-zz Awaiting requested review from vinamratasingal-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gist creation failing
2 participants
@paulirish @brendankenny