Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(runner): support multiple output modes #5154

Merged
merged 4 commits into from
May 9, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

returns support for multiple outputs

I know there's some ugliness in config to get this to work with unified config/CLI settings, but that'll need some good cleanup for type checking soon anyhow

biggest question for 3.0: do we want to have report/output types be string|string[] or string[]

I did the | because it's easier impl wise and won't break common output: 'html' case, but it's new functionality anyhow so now's our chance

@paulirish
Copy link
Member

an idea:

What if the node module always returned an object.
node module also offers lighthouse.generateReport(lhr, type) method publicly.

it takes lhr as first arg. type of string 'html' 'json' or 'csv' as second arg.

but tbh i don't know how it should look in the CLI.

@brendankenny
Copy link
Member

I haven't looked at the code yet, but agree on string|Array<string>. I think the common case will still be the single output mode, so no need to make it harder for that one

@paulirish paulirish added the 3.0 label May 9, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@paulirish paulirish merged commit 5e95e34 into master May 9, 2018
@paulirish paulirish deleted the multiple_outputs branch May 9, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants