Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smokehouse): retry failed tests #5143

Merged
merged 2 commits into from
May 6, 2018
Merged

tests(smokehouse): retry failed tests #5143

merged 2 commits into from
May 6, 2018

Conversation

patrickhulce
Copy link
Collaborator

hopefully to avoid too many manual restarts from NO_NAVSTART and PWA

@GoogleChrome GoogleChrome deleted a comment from googlebot May 6, 2018
paulirish
paulirish approved these changes May 6, 2018
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the approach. much faster than restarting the whole thing.
this is so good.

@paulirish paulirish merged commit 4872e0b into master May 6, 2018
@paulirish paulirish deleted the retry_smokes branch May 6, 2018 21:10
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@patrickhulce @kdzwinel
tests(smokehouse): retry failed tests (GoogleChrome#5143)
8241868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhulce @paulirish