core(tsc): update for new @types/css-font-loading-module #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Apr 28, 2018
| /** @typedef {Exclude<keyof FontFace, 'load'|'loaded'|'status'> | 'display'} FontFaceStringKeys */ | ||
| // All the property keys of FontFace where the value is a string and are worth | ||
| // using for finding font matches (see _findSameFontFamily). | ||
| /** @typedef {'family'|'style'|'weight'|'stretch'|'unicodeRange'|'variant'|'featureSettings'|'display'} FontFaceStringKeys */ |
There was a problem hiding this comment.
was trying to get clever here to automate extraction of the string properties, but turns out there are string properties we don't care about, like status (which is 'unloaded' | 'loading' | 'loaded' | 'error') and not something we'd want to use to try to match up fonts). Easier to just go explicit like this.
paulirish
approved these changes
Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefinitelyTyped/DefinitelyTyped#25045 landed, so can pull out the TODOs adding support for the
FontFaceprops added in the last year.