core(tsc): add type checking to remaining (dbw) gatherers #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Apr 20, 2018
| * @param {!Object} options | ||
| * @return {!Promise<!Array<!Object>>} | ||
| * @param {LH.Gatherer.PassContext} passContext | ||
| * @return {!Promise<LH.Artifacts['JSLibraries']>} |
| @@ -41,27 +42,34 @@ function installMediaListener() { | |||
| } | |||
|
|
|||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
double check that this works being before the typedef 👍
There was a problem hiding this comment.
ok, it does work above or below the jsdoc block, but I moved it below just so it doesn't cause any second guessing some day :)
Unfortunately you still can't merge the comment blocks :(
| @@ -21,8 +21,7 @@ | |||
| "lighthouse-core/lib/emulation.js", | |||
| "lighthouse-core/gather/computed/metrics/*.js", | |||
| "lighthouse-core/gather/connections/**/*.js", | |||
| "lighthouse-core/gather/gatherers/*.js", | |||
| "lighthouse-core/gather/gatherers/seo/*.js", | |||
| "lighthouse-core/gather/gatherers/**/*.js", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type checking now on for all gatherers*!
* with six of them left as
@ts-nocheckThese were a bit more convoluted than some of our more modern gatherers, but hopefully the changes aren't too much to review. No breaking changes; the only test changes needed were two switches from non-underscored properties to underscored ones.
@ts-nocheck(domstats.jsandtags-blocking-first-paint.js) but basic type checking and their artifacts were added.all-event-listeners.jshad the most surgery done as it was gathering way way more info thanno-mutation-eventsneeds. I cut down the collected info to just what was needed (or should obviously also be included).