core(metrics): move first-interactive to first-cpu-idle #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 18, 2018
| } | ||
| }, | ||
| "rawValue": 4927.278, | ||
| "debugString": "First Interactive was 4,930 ms. More details in the \"Performance\" section.", |
There was a problem hiding this comment.
since this is dependent on the other PR, shouldn't this be passing?
also the text still says "first interactive". looks like you need to updatejson, eh
There was a problem hiding this comment.
yeah yeah need to update the JSON it was based on my branch before I updated the json there
patrickhulce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first-interactivetofirst-cpu-idleaccording to the new metric namefirst-interactivecomputed artifact to a metric computed artifactThis is blocked on #4981 since that PR moves away from using first CPU idle for load-fast-4-pwa