core: de-dupe URLs in is-on-http, uses-http2 #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Apr 10, 2018
| @@ -35,13 +35,13 @@ module.exports = [ | |||
| extendedInfo: { | |||
| value: { | |||
| results: { | |||
| length: 18, | |||
There was a problem hiding this comment.
i kinda like being so explicit, though ideally in failure we see exactly where the difference is.
can we avoid dropping back to >15 ?
| }; | ||
| }); |
There was a problem hiding this comment.
instead of this dance should we just do this instead:
const uniqueUrls = Array.from(new Set(resources));
There was a problem hiding this comment.
const uniqueUrls = Array.from(new Set(resources));
unfortunately won't dedupe because it's an object, so they'll all be unique.
We could add it to the filter instead, the Boolean thing is pretty ugly :)
There was a problem hiding this comment.
we're moving this to replace .filter(Boolean)
|
|
||
| const headings = [ | ||
| {key: 'url', itemType: 'url', text: 'Insecure URL'}, | ||
| ]; | ||
|
|
||
| return { | ||
| rawValue: insecureRecords.length === 0, | ||
| rawValue: insecureURLs.length === 0, |
There was a problem hiding this comment.
sure, doesn't matter :)
|
how's it lookin' now @paulirish ? |
paulirish
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix our recent CI flakes too :)