core(is-on-https): consider about:* secure #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A more involved fix is flipping nonApplicable to true in this case. Also it looks like
lol that this was reported. :) |
|
@paulirish how about when on an HTTPS page? elawrence's comment seemed like this was legit. I'm not sure we should flag abouts as there's no action item to convert about:blank into an HTTPS URL is there? does an about:blank iframe on an https page do anything bad?
|
|
I see, okay. So we're focused on about:blank as a resource/iframe on the page rather than the root document itself. Okay, fine then. :) This makes sense. Also good luck trying to audit a root 'about:blank' page. :p |
paulirish
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes crbug.com/810709