core(start_url): fix start_url audit while offline #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
changed the title
wardpeet
force-pushed
the
bug/start-url-cached
branch
from
93373be
to
5c9696c
Compare
wardpeet
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
wardpeet
force-pushed
the
bug/start-url-cached
branch
from
431c97b
to
9ef1084
Compare
wardpeet
changed the title
wardpeet
changed the title
wardpeet
changed the title
wardpeet
force-pushed
the
bug/start-url-cached
branch
from
557b4f8
to
2a1a385
Compare
wardpeet
force-pushed
the
bug/start-url-cached
branch
from
b9f6a72
to
cf70143
Compare
|
Some test urls that have failed before |
|
@wardpeet: not sure if @paulirish mentioned this to you somewhere else, but we'll have to stick to promises in this file for now because we want it in the 2.x branch, which doesn't drop Node 6 |
paulirish
approved these changes
Mar 21, 2018
patrickhulce
approved these changes
Mar 22, 2018
paulirish
pushed a commit
that referenced
this pull request
Mar 22, 2018
* Load manifest in online mode but execute fetch of start_url in offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are broken but I want some feedback on this one.
is this a good approach? It seems to work on some urls I've tested but should test more of them
It fixes #2576