Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(font-size): make font size artifact serializable #4194

Merged
merged 2 commits into from
Jan 8, 2018
Merged

core(font-size): make font size artifact serializable #4194

merged 2 commits into from
Jan 8, 2018

Conversation

kdzwinel
Copy link
Collaborator

@kdzwinel kdzwinel commented Jan 6, 2018 •
edited
Loading

Fixes #4184

WebInspector.CSSStyleDeclarations have circular structure making them non-serializable.

I created SimplifiedStyleDeclaration type definition to make jsdoc comments more readable.

paulirish
paulirish approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thx

@paulirish paulirish merged commit 13b0405 into GoogleChrome:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdzwinel @paulirish @devtools-bot