Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(perf-audits): adjust presentation of runtime cost audits #4020

Merged
merged 3 commits into from
Dec 11, 2017

Conversation

paulirish
Copy link
Member

I noticed and fixed some inconsistencies

  • main thread work breakdown was always showing in diagnostics, even if total cost was just 40ms.
  • bootup time audit was saying "is high" but only when the audit was passing.
  • now the failure threshold for the two audits is adjusted.
    • just JS bootup times costing more than 2s, show it. total main thread time costing more than 4s, show that.

@vinamratasingal-zz
Copy link

Silly question- are there any UX changes to the report itself? Otherwise, I don't have any input on the logic changes.

@paulirish
Copy link
Member Author

  • i'm changing when both audits show up vs get put into "Passed Audits"
  • The title of "JavaScript boot-up time is high (> 4s)" (which you see in the report), i'm changing to just "JavaScript boot-up time".

@vinamratasingal-zz
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants