Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump ws to 3.3.2 #3949

Merged
merged 1 commit into from
Nov 30, 2017
Merged

deps: Bump ws to 3.3.2 #3949

merged 1 commit into from
Nov 30, 2017

Conversation

crimeminister
Copy link
Contributor

@crimeminister crimeminister commented Nov 29, 2017

Remediate security vulnerability in ws@1.1.2 by updating to recent version. Here is the security advisory.

closes #3948

Remediate security vulnerability in ws@1.1.2 by updating to recent version.
Cf. https://nodesecurity.io/advisories/550
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through the breaking changes since 1.x and didn't seem like we were using any of them, so lgtm! 👍

thanks again for finding and fixing @crimeminister! 🎉

@paulirish paulirish merged commit 3bdb56e into GoogleChrome:master Nov 30, 2017
@crimeminister crimeminister deleted the fix/bump-dependency-ws branch November 30, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node security advisory for ws@1.1.2
3 participants