Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add support for changelog.json in Node #1823

Merged
merged 3 commits into from
Jan 25, 2023
Merged

feat(node): add support for changelog.json in Node #1823

merged 3 commits into from
Jan 25, 2023

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 24, 2023

Adds support for changelog.json to Node.js, tested here:

bcoe/google-cloud-node#5

@bcoe bcoe requested a review from a team as a code owner January 24, 2023 21:00
@bcoe bcoe requested a review from a team January 24, 2023 21:00
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 24, 2023
chingor13
chingor13 requested changes Jan 24, 2023
View reviewed changes
src/strategies/node.ts Outdated Show resolved Hide resolved
@bcoe bcoe requested a review from chingor13 January 25, 2023 16:11
@chingor13 chingor13 merged commit d3e3bd3 into main Jan 25, 2023
@chingor13 chingor13 deleted the node-support-changelog-json branch January 25, 2023 16:46
@release-please release-please bot mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoe @chingor13