Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum OpenTelemetry version to support type checks #1038

Closed
plamut opened this issue Oct 31, 2021 · 3 comments · Fixed by #1050
Closed

Bump minimum OpenTelemetry version to support type checks #1038

plamut opened this issue Oct 31, 2021 · 3 comments · Fixed by #1050
Assignees
@plamut
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@plamut
Copy link
Contributor

plamut commented Oct 31, 2021

See the following comment for details: #1036 (comment)

If confirmed, we should bump to at least opentelemetry-*==1.1.0, and adjust our OpenTelemetry logic to the changes in the library API.
@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Oct 31, 2021
@plamut plamut self-assigned this Oct 31, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 31, 2021
@plamut plamut mentioned this issue Oct 31, 2021
Merged
4 tasks
@tswast
Copy link
Contributor

tswast commented Nov 1, 2021

Good discovery. Bummer there were breaking changes.

Looks like Spanner has already updated, so we'll need this for compatibility with them as well. googleapis/python-spanner#358

@plamut
Copy link
Contributor Author

plamut commented Nov 1, 2021

I see they bumped it to >= 1.1.0, thus we should probably just do the same.

@tswast tswast added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: process A process-related concern. May include testing, release, or the like. labels Nov 1, 2021
@tswast
Copy link
Contributor

tswast commented Nov 1, 2021

Switching to type bug, since I believe our client will break if installed in the same environment as a Spanner client (and opentelemetry is installed)

@plamut plamut changed the title Bump minimum openetelemetry version to support type checks Bump minimum OpenTelemetry version to support type checks Nov 5, 2021
@plamut plamut mentioned this issue Nov 5, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: support OpenTelemetry >= 1.1.0 plamut/python-bigquery
2 participants
@tswast @plamut