From 25b4acdc0df373a4621d6e8eda9933ada6cba75f Mon Sep 17 00:00:00 2001 From: Chalmer Lowe Date: Tue, 25 Oct 2022 14:27:37 +0000 Subject: [PATCH 1/3] Sets cache support to false, removes upper req limit --- setup.py | 2 +- sqlalchemy_bigquery/base.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 4afe003e..3d876748 100644 --- a/setup.py +++ b/setup.py @@ -91,7 +91,7 @@ def readme(): # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/386 # and # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/385 - "sqlalchemy>=1.2.0,<=1.4.27", + "sqlalchemy>=1.2.0", "future", ], extras_require=extras, diff --git a/sqlalchemy_bigquery/base.py b/sqlalchemy_bigquery/base.py index 3a26b330..32247a45 100644 --- a/sqlalchemy_bigquery/base.py +++ b/sqlalchemy_bigquery/base.py @@ -733,6 +733,7 @@ class BigQueryDialect(DefaultDialect): supports_default_values = False supports_empty_insert = False supports_multivalues_insert = True + supports_statement_cache = False supports_unicode_statements = True supports_unicode_binds = True supports_native_decimal = True From 48d920c8b416e50034d2bb70239b65618097f906 Mon Sep 17 00:00:00 2001 From: Chalmer Lowe Date: Tue, 25 Oct 2022 14:27:37 +0000 Subject: [PATCH 2/3] fix: Sets cache support to false, removes upper req limit --- setup.py | 2 +- sqlalchemy_bigquery/base.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 4afe003e..3d876748 100644 --- a/setup.py +++ b/setup.py @@ -91,7 +91,7 @@ def readme(): # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/386 # and # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/385 - "sqlalchemy>=1.2.0,<=1.4.27", + "sqlalchemy>=1.2.0", "future", ], extras_require=extras, diff --git a/sqlalchemy_bigquery/base.py b/sqlalchemy_bigquery/base.py index 3a26b330..32247a45 100644 --- a/sqlalchemy_bigquery/base.py +++ b/sqlalchemy_bigquery/base.py @@ -733,6 +733,7 @@ class BigQueryDialect(DefaultDialect): supports_default_values = False supports_empty_insert = False supports_multivalues_insert = True + supports_statement_cache = False supports_unicode_statements = True supports_unicode_binds = True supports_native_decimal = True From 65d51eebf1c08b2afb2e189c7c7a6520b1153a4c Mon Sep 17 00:00:00 2001 From: Chalmer Lowe Date: Thu, 10 Nov 2022 17:57:12 +0000 Subject: [PATCH 3/3] Removes OBE comments regarding max version number --- setup.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/setup.py b/setup.py index 3d876748..b03e9bb2 100644 --- a/setup.py +++ b/setup.py @@ -86,11 +86,6 @@ def readme(): "google-cloud-bigquery>=2.25.2,<4.0.0dev", "google-cloud-bigquery-storage>=2.0.0,<3.0.0dev", "pyarrow>=3.0.0,<7.0dev", - # Temporarily set maximimum sqlalchemy to a known-working version while - # we debug failing compliance tests. See: - # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/386 - # and - # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/385 "sqlalchemy>=1.2.0", "future", ],