Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "future" dependency #542

Merged
merged 13 commits into from
Jun 12, 2023
Merged

fix: remove "future" dependency #542

merged 13 commits into from
Jun 12, 2023

Conversation

domsj
Copy link
Contributor

@domsj domsj commented Jan 5, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #541 🦕

@domsj domsj requested a review from a team as a code owner January 5, 2023 11:49
@domsj domsj requested a review from a team January 5, 2023 11:49
@domsj domsj requested a review from a team as a code owner January 5, 2023 11:49
@google-cla
Copy link

google-cla bot commented Jan 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 5, 2023
@parthea parthea changed the title remove "future" dependency fix: remove "future" dependency Jan 7, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2023
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 7, 2023
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 7, 2023
@domsj
Copy link
Contributor Author

domsj commented Jan 31, 2023

ping

@Giuzzilla
Copy link

@domsj While you wait for the contributors to review this, I suggest rebasing against main (should fix the failing tests)

@meredithslota meredithslota removed the request for review from kurtisvg March 14, 2023 17:58
@domsj domsj requested a review from a team as a code owner March 22, 2023 17:25
@domsj
Copy link
Contributor Author

domsj commented Apr 24, 2023

guys, just merge it already

@meredithslota
Copy link

Hi @domsj — thank you so much for submitting. We've had some team changes recently and are figuring out how to regroup, apologies for the delay here. I appreciate the contribution!

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2023
@domsj
Copy link
Contributor Author

domsj commented Jun 12, 2023

@chalmerlowe @parthea please approve & merge

@chalmerlowe
Copy link
Collaborator

@domsj
I will try to look this over today. Waiting on the tests to pass.

@domsj
Copy link
Contributor Author

domsj commented Jun 12, 2023

@domsj I will try to look this over today. Waiting on the tests to pass.

@chalmerlowe I think you (or someone else) needs to (re-)approve running the tests. They succeeded before, but need to run again after I merged in latest master (because there was a conflict in the meantime)

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2023
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2023
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approval

@chalmerlowe
Copy link
Collaborator

Thanks @domsj. Appreciate the help.

@chalmerlowe chalmerlowe merged commit ba5e244 into googleapis:main Jun 12, 2023
@domsj domsj deleted the no-future branch June 12, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove dependency on "future"
6 participants