-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove "future" dependency #542
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ping |
@domsj While you wait for the contributors to review this, I suggest rebasing against main (should fix the failing tests) |
guys, just merge it already |
Hi @domsj — thank you so much for submitting. We've had some team changes recently and are figuring out how to regroup, apologies for the delay here. I appreciate the contribution! |
@chalmerlowe @parthea please approve & merge |
@domsj |
@chalmerlowe I think you (or someone else) needs to (re-)approve running the tests. They succeeded before, but need to run again after I merged in latest master (because there was a conflict in the meantime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approval
Thanks @domsj. Appreciate the help. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #541 🦕