Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat(samples): add Transcoder samples #8

Merged
merged 20 commits into from
Nov 18, 2020
Merged

feat(samples): add Transcoder samples #8

merged 20 commits into from
Nov 18, 2020

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Nov 9, 2020

b:160888570

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2020
@irataxy irataxy mentioned this pull request Nov 9, 2020
Closed
@codecov
Copy link

codecov bot commented Nov 9, 2020 •
edited
Loading

Codecov Report

Merging #8 (c3be93f) into master (39d9785) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files           5        5           
  Lines        1575     1575           
  Branches       59       60    +1     
=======================================
  Hits         1516     1516           
  Misses         58       58           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d9785...c3be93f. Read the comment docs.

ipotuzhnov
ipotuzhnov approved these changes Nov 9, 2020
View reviewed changes
samples/package.json Outdated Show resolved Hide resolved
sofisl
sofisl suggested changes Nov 11, 2020
View reviewed changes
samples/createJobFromPreset.js Outdated Show resolved Hide resolved
samples/createJobFromPreset.js Show resolved Hide resolved
samples/test/transcoder.test.js Outdated Show resolved Hide resolved
samples/test/transcoder.test.js Show resolved Hide resolved
@snippet-bot
Copy link

snippet-bot bot commented Nov 12, 2020 •
edited
Loading

Here is the summary of possible violations 😱

There are 11 possible violations for not having product prefix.

Here is the summary of changes.

You added 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

ipotuzhnov
ipotuzhnov approved these changes Nov 13, 2020
View reviewed changes
samples/test/transcoder.test.js Show resolved Hide resolved
@sofisl sofisl added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2020
@sofisl
Copy link
Contributor

sofisl commented Nov 17, 2020

@irataxy, FYI test is failing again:

1) "before all" hook in "{root}":
     Error: kokoro-system-test@long-door-651.iam.gserviceaccount.com does not have storage.objects.list access to the Google Cloud Storage bucket.
      at new ApiError (node_modules/@google-cloud/common/build/src/util.js:59:15)
      at Util.parseHttpRespBody (node_modules/@google-cloud/common/build/src/util.js:194:38)
      at Util.handleResp (node_modules/@google-cloud/common/build/src/util.js:135:117)
      at /workspace/samples/node_modules/@google-cloud/common/build/src/util.js:434:22
      at onResponse (node_modules/retry-request/index.js:214:7)
      at /workspace/samples/node_modules/teeny-request/build/src/index.js:219:13
          -> /workspace/samples/node_modules/teeny-request/src/index.ts:325:11
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

@bcoe bcoe changed the title (feat) add Transcoder samples feat(samples): add Transcoder samples Nov 17, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@sofisl sofisl merged commit 7bf59c3 into googleapis:master Nov 18, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 2, 2020
@release-please
chore: release 1.1.0 (#10)
96a6493 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.1.0](https://github.com/googleapis/nodejs-video-transcoder/compare/v1.0.1...v1.1.0) (2020-11-30)


### Features

* **samples:** add Transcoder samples ([#8](https://github.com/googleapis/nodejs-video-transcoder/issues/8)) ([7bf59c3](https://github.com/googleapis/nodejs-video-transcoder/commit/7bf59c3c9defa1675d07083578b3d3acc9f3fca8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoe bcoe bcoe left review comments

@ipotuzhnov ipotuzhnov ipotuzhnov approved these changes

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@irataxy @sofisl @bcoe @ipotuzhnov @yoshi-kokoro