This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
fix: synth.py clean up for multiple version #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 8 8
Lines 11563 11565 +2
Branches 423 423
=======================================
+ Hits 11360 11362 +2
Misses 199 199
Partials 4 4
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Jun 1, 2020
sofisl
approved these changes
Jun 1, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://github.com/googleapis/nodejs-datacatalog/compare/v2.0.0...v2.1.0) (2020-06-16) ### Features * add order field to TagField and TagTemplateField ([#157](https://github.com/googleapis/nodejs-datacatalog/issues/157)) ([70c23c2](https://github.com/googleapis/nodejs-datacatalog/commit/70c23c2b609bd24901dc902090e23fbf92b55895)) * move ts target to es2018 from es2016 ([#172](https://github.com/googleapis/nodejs-datacatalog/issues/172)) ([e354dde](https://github.com/googleapis/nodejs-datacatalog/commit/e354ddeeeedd3e106c50ed579075f23c9d9c5bb5)) * promote library to GA ([#177](https://github.com/googleapis/nodejs-datacatalog/issues/177)) ([ac11090](https://github.com/googleapis/nodejs-datacatalog/commit/ac110906b723f362024318295e3de6743c905b7e)) ### Bug Fixes * proper fallback option handling ([51df672](https://github.com/googleapis/nodejs-datacatalog/commit/51df6721306ab6d2d9bf6919b0f3f432ca85b4ab)) * regenerate unit tests ([#163](https://github.com/googleapis/nodejs-datacatalog/issues/163)) ([4593117](https://github.com/googleapis/nodejs-datacatalog/commit/45931176d266d364e0508039cf6a4e284ad2923d)) * synth.py clean up for multiple version ([#167](https://github.com/googleapis/nodejs-datacatalog/issues/167)) ([c799604](https://github.com/googleapis/nodejs-datacatalog/commit/c799604b2d29269006ff39748afb78302ce46ca2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't get response from datacatalog API producer team, I hack the synthtool to keep the beta version to explore.
The hack should be removed when next break change release