fix: handle fallback option properly #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
…secrets.sh Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Author: BenWhitehead <BenWhitehead@users.noreply.github.com> Source-Date: Wed Jun 10 22:24:28 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: e7034945fbdc0e79d3c57f6e299e5c90b0f11469 Source-Link: googleapis/synthtool@e703494
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 96.61% 96.95% +0.33%
==========================================
Files 5 5
Lines 1715 1709 -6
Branches 83 77 -6
==========================================
Hits 1657 1657
+ Misses 56 50 -6
Partials 2 2
Continue to review full report at Codecov.
|
alexander-fenster
changed the title
alexander-fenster
approved these changes
Jun 12, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://github.com/googleapis/nodejs-bigquery-storage/compare/v2.0.0...v2.1.0) (2020-06-12) ### Features * **secrets:** begin migration to secret manager from keystore ([#70](https://github.com/googleapis/nodejs-bigquery-storage/issues/70)) ([6513e8c](https://github.com/googleapis/nodejs-bigquery-storage/commit/6513e8cf6195740b570b39fb645d8a1adafc0580)) ### Bug Fixes * handle fallback option properly ([#73](https://github.com/googleapis/nodejs-bigquery-storage/issues/73)) ([ec6b88c](https://github.com/googleapis/nodejs-bigquery-storage/commit/ec6b88cf87bf45e0f16935b8b27f15447aa385b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/7da6772a-9936-4517-9a1e-9ac2abc50d18/targets
Source-Link: googleapis/synthtool@e703494