Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dep from package #88

Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix: remove dep from package #88

merged 1 commit into from
Feb 9, 2021

Conversation

grant
Copy link
Contributor

@grant grant commented Feb 1, 2021

node-fetch is only used for generating docs. Removes from deps.

@grant
fix: remove dep from package
dbfb52e 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant self-assigned this Feb 1, 2021
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. label Feb 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2021
@grant grant requested a review from grayside February 4, 2021 00:02
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2021
@grant grant merged commit 2b0ba10 into master Feb 9, 2021
@grant grant deleted the grant_dev_deps branch February 9, 2021 19:22
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 9, 2021
@yoshi-code-bot
chore: release 4.0.1 (#89)
dea16e8 
🤖 I have created a release \*beep\* \*boop\* 
---
### [4.0.1](https://github.com/googleapis/google-cloudevents-nodejs/compare/v4.0.0...v4.0.1) (2021-02-09)


### Bug Fixes

* remove dep from package ([#88](https://github.com/googleapis/google-cloudevents-nodejs/issues/88)) ([2b0ba10](https://github.com/googleapis/google-cloudevents-nodejs/commit/2b0ba10187d791e378aa67e85ddab060d2065b10))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

@michaelawyu michaelawyu Awaiting requested review from michaelawyu

@grayside grayside Awaiting requested review from grayside

Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @averikitsch