-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informational headers to gRPC requests sent for datastore #2230
Comments
#2221 is broader than this issue would suggest. |
@tseaver Focusing on the datastore case, this is a bit awkward even as-is. The But the WDYT about removing the |
The |
|
That example delgates to the connection's |
Gotcha! That was just "laziness" to get the implementation to fit. I've got a speculative PR in the works, coming soon. We can chat about that? |
Hello, As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates. My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request. Thank you! |
@lukesneeringer, could we re-open this? We are still interested in having this header added to gRPC requests:
(This functionality is already in place for Spanner and Firestore.) This is may not be relevant for all APIs, so I think this is the right issue to re-open as opposed to #2221. Thanks! |
See googleapis/google-cloud-node#1542
We need to modify the headers being sent to:
Though we may want to do this on a per-request basis. Probably not, since
self._user_agent
doesn't change after theMetadataPlugin
object is created, even if the user agent on the originalClient
has changed.The text was updated successfully, but these errors were encountered: