feat: [maps-routiting] new module for maps-routiting #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
requested changes
Nov 3, 2022
.bash_history
Outdated
| @@ -0,0 +1,5 @@ | |||
| pwd | |||
There was a problem hiding this comment.
Did you intend to include this?
gapic-libraries-bom/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.google.maps</groupId> | ||
| <artifactId>google-maps-routes-bom</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version><!-- {x-version-update:google-maps-routes:current} --> |
There was a problem hiding this comment.
We need to exclude it from here by updating the script that re-generates the bom.
generation/hermetic_build/Dockerfile
Outdated
|
|
||
| ########################################################## | ||
| # Build the command-line tool that lets us sign JWTs. | ||
| FROM rust:1.49-buster |
There was a problem hiding this comment.
This file doesn't seem to be relevant.
suztomo
commented
Nov 3, 2022
Comment on lines
+20
to
+23
| if [[ "$groupId_line" == *"com.google.maps"* ]]; then | ||
| # The gapic bom includes cloud libraries | ||
| continue | ||
| fi |
There was a problem hiding this comment.
@meltsufin This excludes the newly added library from the gapic bom (and thus from libraries-bom).
meltsufin
approved these changes
Nov 3, 2022
Merged
|
There was a typo! |
|
Oops. Routiting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by
suztomo@suztomo:~/google-cloud-java$ python3.9 generation/new_client/new-client.py generate --api_shortname=maps-routiting --proto-path=google/maps/routing --name-pretty="Routes API" --product-docs="https://developers.google.com/maps/documentation/routes" --api-description="Routes API is the next generation, performance optimized version of the existing Directions API and Distance Matrix API. It helps you find the ideal route from A to Z, calculates ETAs and distances for matrices of origin and destination locations, and also offers new features." --api-id=routes.googleapis.com --cloud-api=false --requires-billing=false --distribution-name="com.google.maps:google-maps-routes"