Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove certification expiration workaround #781

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix: remove certification expiration workaround #781

merged 2 commits into from
Dec 20, 2021

Conversation

amchiclet
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #781 (19603ce) into main (325a609) will decrease coverage by 0.82%.
The diff coverage is 53.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   69.97%   69.15%   -0.83%     
==========================================
  Files           7        7              
  Lines        1209     1248      +39     
  Branches       57       58       +1     
==========================================
+ Hits          846      863      +17     
- Misses        362      384      +22     
  Partials        1        1              
Impacted Files Coverage Δ
src/index.ts 54.86% <0.00%> (-0.20%) ⬇️
src/logger.ts 67.05% <56.45%> (-18.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50cb620...19603ce. Read the comment docs.

@amchiclet amchiclet added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 17, 2021
@amchiclet amchiclet marked this pull request as ready for review December 17, 2021 03:07
@amchiclet amchiclet requested a review from a team as a code owner December 17, 2021 03:07
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 20, 2021
@nolanmar511 nolanmar511 merged commit 44af460 into googleapis:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants