fix(AIP-4232): correct repeated field check #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We misinterpreted the requirement in AIP-4232 around where
repeatedfields can be in agoogle.api.method_signatureentry.Previously, we thought
repeatedfields could only be the last field in the entry altogether. It is actually only allowed to be a the last field in a dot-notation chain accessing a field. That is to say, we must ensure that in a entry's field reference using dot-notation, only the last field in that chain can be repeated.Also fixes a bug in
FindFieldDotNotationwhere if the last field in the dot-notation chain is a message, it attempts to keep going and returnsnilwhen it should really just return the field.Internal bug b/317794116