Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-121): lint for mutable reference cycles #1238

Merged
merged 8 commits into from
Aug 29, 2023
Merged

feat(AIP-121): lint for mutable reference cycles #1238

merged 8 commits into from
Aug 29, 2023

Conversation

noahdietz
Copy link
Collaborator

Introduces rules to lint for mutable resource reference cycles.

Fixes #1109

@noahdietz noahdietz requested a review from a team as a code owner August 16, 2023 21:23
toumorokoshi
toumorokoshi suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! mostly minor nits. Main comment is on whether we can detect deeper cycles.

rules/aip0121/no_cycles.go Outdated Show resolved Hide resolved
docs/rules/0121/no-cycles.md Outdated Show resolved Hide resolved
docs/rules/0121/no-cycles.md Outdated Show resolved Hide resolved
docs/rules/0121/no-cycles.md Outdated Show resolved Hide resolved
toumorokoshi
toumorokoshi approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple suggestions but nothing blocking.

This is really cool, thanks for adding this.

rules/aip0121/no_mutable_cycles.go Outdated Show resolved Hide resolved
rules/aip0121/no_mutable_cycles.go Outdated Show resolved Hide resolved
@noahdietz noahdietz added the automerge Summon MOG for automerging label Aug 29, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit a3895eb into googleapis:main Aug 29, 2023
6 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Aug 29, 2023
@release-please release-please bot mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-121: lint against cyclic references
2 participants
@noahdietz @toumorokoshi