Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude patterns not working as expected #121

Closed
pereorga opened this issue May 31, 2023 · 3 comments · Fixed by #124
Closed

Exclude patterns not working as expected #121

pereorga opened this issue May 31, 2023 · 3 comments · Fixed by #124

Comments

@pereorga
Copy link

pereorga commented May 31, 2023

I have the following .yamlfmt file in my project:

include:
  - .
  - .yamlfmt
exclude:
  - node_modules

The idea is to include all *.yml / *.yaml files in the project, including hidden files, but excluding some directories such as dependency directories (node_modules in this case). But for some reason this is isn't working, node_modules is still checked if . is included.

I may be missing something. What would be an alternative approach? I don't want to maintain a list of files and directories to include.

@braydonk
Copy link
Collaborator

braydonk commented Jun 5, 2023

Hi @pereorga thanks for opening an issue.

I would have expected that config to work. I can spend some time debugging tonight to try and find the issue.

@braydonk
Copy link
Collaborator

braydonk commented Jun 7, 2023

Found the issue, it should be fixed in the next release of yamlfmt. Not sure yet when I will be able to get that out but I will try within the next couple of weeks.

@esn89
Copy link

esn89 commented Jul 12, 2023

Thanks @braydonk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants