Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts without a "ẞ" are still displayed with "German" language filter #8142

Open
thlinard opened this issue Sep 6, 2024 · 6 comments
Open

Comments

@thlinard
Copy link
Contributor

thlinard commented Sep 6, 2024

Describe the issue
According to https://github.com/googlefonts/lang/blob/main/Lib/gflanguages/data/languages/de_Latn.textproto (#153), ẞ is a required character and glyph for German support.

However, with the new language filter system on the website, if you select "German", you get fonts that do not have a ẞ.

To Reproduce
Select the language filter "German" and put an ẞ in Preview, like this: https://fonts.google.com/?preview.text=%E1%BA%9E&lang=de_Latn

@emmamarichal
Copy link
Collaborator

I still see not_required: "ẞ" in the .textproto.

But indeed, this character is now considered as the official one (instead of SS).
There were discussions about this a few weeks ago, @davelab6, what were the conclusions? Should we work on updating this filter, so that fonts that don't have this character are removed from the list?

@thlinard
Copy link
Contributor Author

I still see not_required: "ẞ" in the .textproto.

Oh, my mistake. "ẞ" is both in "base" (what misled me) and in "not_required".

But indeed the conclusion of (#153) was to make it a required character.

@emmamarichal
Copy link
Collaborator

Yes, I don't know yet for the old fonts, but for the new ones, this character is definitely required :)

@thlinard
Copy link
Contributor Author

thlinard commented Sep 11, 2024

Dave was more specific in (#152):

Alright, I am convinced that, if a user searches for fonts that support German, and then Roboto, Poppins, Lato etc should not come up.

@emmamarichal
Copy link
Collaborator

@davelab6 @chrissimpkins I let you plan/assign this work!

@chrissimpkins
Copy link
Collaborator

Discussed with Nate today. The filter fix is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants